Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing tests #293

Merged
merged 1 commit into from
Nov 9, 2021
Merged

Conversation

aziiee
Copy link
Contributor

@aziiee aziiee commented Oct 21, 2021

This will also make the required changes after bumping faker.

@aziiee aziiee marked this pull request as draft October 21, 2021 17:16
@aziiee aziiee force-pushed the add-missing-tests branch 6 times, most recently from b7498e3 to a4747c9 Compare October 26, 2021 13:27
@aziiee aziiee requested a review from czosel October 26, 2021 13:44
@aziiee aziiee marked this pull request as ready for review October 26, 2021 14:06
@czosel czosel requested a review from velrest October 26, 2021 14:42
This will also make the required changes after bumping `faker`.
Copy link
Contributor

@czosel czosel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@czosel czosel merged commit bbb972b into projectcaluma:main Nov 9, 2021
github-actions bot pushed a commit that referenced this pull request Nov 9, 2021
# [2.0.0](v1.1.0...v2.0.0) (2021-11-09)

### Bug Fixes

* **translations:** use better naming for "ACL" ([#299](#299)) ([73bb397](73bb397))
* add missing tests ([#293](#293)) ([bbb972b](bbb972b))
* allow to clear select in meta fields ([#294](#294)) ([6428909](6428909))
* data table paging ([#296](#296)) ([f8e8c63](f8e8c63))
* redirect to /users on index ([#270](#270)) ([146d6f3](146d6f3))
* sort user list by last name ([#274](#274)) ([c72cb81](c72cb81))

### chore

* drop support for node 10 ([#295](#295)) ([96e5335](96e5335))

### Features

* extract meta fields rendering into a component ([#277](#277)) ([2527ed5](2527ed5))
* **scopes:** display corresponding ACLs ([#275](#275)) ([0daa8b0](0daa8b0))
* **scopes:** introduce meta fields ([#272](#272)) ([af82ec2](af82ec2))
* make addon configurable via config service ([#269](#269)) ([3a56283](3a56283))

### BREAKING CHANGES

* drop support for node 10 as it has reached EOL.

Co-authored-by: Akanksh Saxena <[email protected]>
@velrest
Copy link
Contributor

velrest commented Nov 9, 2021

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants