fix(pagination): only check if strings are empty so they are not seri…

…alized as an empty qp
projectcaluma · Jun 30, 2020 · d79e0a4 · d79e0a4
1 parent a75074c
commit d79e0a4
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/addon/controllers/pagination.js b/addon/controllers/pagination.js
@@ -13,6 +13,11 @@ export default class PaginationController extends Controller {
 
   @action
   updateQueryParam(field, value) {
-    this.router.transitionTo({ queryParams: { [field]: value || null } });
+    // We dont want to set an empty stirng as this is still serialized
+    if (typeof value === "string" && !value.length) {
+      value = null;
+    }
+
+    this.router.transitionTo({ queryParams: { [field]: value } });
   }
 }