Fix two issues that resulted in incorrect updateTypes #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nelljerram
approved these changes
Nov 7, 2017
glide.lock
Outdated
| @@ -43,7 +43,7 @@ imports: | |||
| - name: github.com/emicklei/go-restful-swagger12 | |||
| version: dcef7f55730566d41eae5db10e7d6981829720f6 | |||
| - name: github.com/gavv/monotime | |||
There was a problem hiding this comment.
Aside: do we still need monotime here?
- Force snapshot updates to have updateType=new, this makes sense because they are new to Felix even if they're the result of updates for Typha. Add machinery to the FVs to check. - The new machinery found a flake, which I tracked down to Workiva/go-datastructures#180 pin go-datastructures to pick up the fix: Workiva/go-datastructures#182.
fasaxc
force-pushed
the
fix-update-type
branch
from
b90eba2 to
caae1fb
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Force snapshot updates to have updateType=new, this makes sense because they are new to Felix even if they're the result of updates for Typha. Add machinery to the FVs to check.
The new machinery found a flake, which I tracked down to Ctrie read-only snapshot changes after creation Workiva/go-datastructures#180 pin go-datastructures to pick up the fix: RM-24272 Fix that read-only snapshots shared state with original. Workiva/go-datastructures#182.
Fixes #68
Fixes #69
Todos
Release Note