-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to netlink.RouteListFilteredIter() API #9139
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvin-tigera
added
release-note-required
Change has user-facing impact (no matter how small)
docs-pr-required
Change is not yet documented
labels
Aug 15, 2024
fasaxc
force-pushed
the
netlink-iter
branch
6 times, most recently
from
August 21, 2024 15:36
8f10407
to
47229b8
Compare
fasaxc
added
docs-not-required
Docs not required for this change
and removed
docs-pr-required
Change is not yet documented
labels
Aug 22, 2024
aaaaaaaalex
approved these changes
Aug 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one potential change, might be nothing
Just holding this back until I've got the RouteTable merge to Enterprise done. Might want to upstream some of the fixes there and I don't want this to conflict... |
Should significantly reduce allocations from netlink when there are many routes.
Noticed the default DeepEquals option was a hot spot when profiling RouteTable.
Allocate one scrate netlink.Route and re-use to avoid spilling every route to the heap.
Saves copies as the set size grows.
Get is less expensive so it's worth it if the route hasn't changed (the mainline).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
docs-not-required
Docs not required for this change
release-note-required
Change has user-facing impact (no matter how small)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Optimise RouteTable resync methods:
Add benchmark for resync with various numbers of routes.
Switch to netlink.RouteListFilteredIter() API, which avoids a series of large slice allocations.
Use benchmark to find more wins:
Overall, significantly reduces allocations from when there are many routes to resync and significantly increases performance.
Benchmarks for resyncing 64k routes; 50% reduction in resync time; 80% saving in bytes allocated; GC-included CPU usage down by 60%.
Related issues/PRs
Follow on from #8979
CORE-10626
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*
label.docs-pr-required
: This change requires a change to the documentation that has not been completed yet.docs-completed
: This change has all necessary documentation completed.docs-not-required
: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*
label.release-note-required
: This PR has user-facing changes. Most PRs should have this label.release-note-not-required
: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate
: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr
: This PR is related to install and requires a corresponding change to the operator.