Remove remaining node update calls in calico-node startup

[skmatti]

Description

Remove node update on startup if CALICO_NETWORKING_BACKEND=none. Followup to #7550

Related issues/PRs

Release Note

None

Reminder for the reviewer

Make sure that this PR has the correct labels and milestone set.

Every PR needs one docs-* label.

• docs-pr-required: This change requires a change to the documentation that has not been completed yet.
• docs-completed: This change has all necessary documentation completed.
• docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

• release-note-required: This PR has user-facing changes. Most PRs should have this label.
• release-note-not-required: This PR has no user-facing changes.

Other optional labels:

• cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
• needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

[skmatti]

@mgleung Can you take a look?. Thanks

[caseydavenport]

Just need to swap the ordering of the || clauses but otherwise this LGTM, will trigger tests once that is updated

[caseydavenport]

/sem-approve

[caseydavenport]

Not sure if you've looked into this, but it would be nice to have some sort of simply unit test verifying that this behavior doesn't get regressed.

e.g., a UT that queries the node, makes note of its revision, runs this code, and verifies the revision is unchanged?

[skmatti]

Not sure if you've looked into this, but it would be nice to have some sort of simply unit test verifying that this behavior doesn't get regressed.

e.g., a UT that queries the node, makes note of its revision, runs this code, and verifies the revision is unchanged?

Do you mean a FV test like

calico/node/pkg/lifecycle/startup/startup_test.go

Line 988 in 31bef1e

var _ = Describe("FV tests against K8s API server.", func() {

?

[caseydavenport]

@skmatti yep, that file is probably the right place for it to go.

I'm going to merge this for now so that it doesn't rot, but if you can I think it would be great to do a follow-on that adds such a test. Feel free to ping me here or on another PR and we work through it!