Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable DaemonSet rolling-update in manifests #1506

Merged

Conversation

caseydavenport
Copy link
Member

@caseydavenport caseydavenport commented Dec 14, 2017

Description

Fixes #1272

This enables rolling update by default in the DaemonSet, which means users can now simply apply the new manifest and Calico will be upgraded.

Todos

  • Tests
  • Documentation
  • Release note

Release Note

Rolling update is now enabled by default in the Kubernetes self-hosted manifests

@caseydavenport caseydavenport added the release-note-required Change has user-facing impact (no matter how small) label Dec 14, 2017
@caseydavenport caseydavenport added this to the Calico v3.0.0 milestone Dec 14, 2017
Copy link
Member

@ozdanborne ozdanborne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@robbrockbank robbrockbank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conceptually fine to me - but don't know enough about the manifests to say it;s correct.

@caseydavenport caseydavenport merged commit 726931d into projectcalico:master Dec 14, 2017
@caseydavenport caseydavenport deleted the enable-rolling-update branch December 14, 2017 21:40
@nelljerram
Copy link
Member

And I guess it's sufficient for these additions to be in the new manifest, right? So specifically, when upgrading from a 2.6.4 manifest to 3.0.0, it is correct to say that we don't need these additions in the 2.6.4 manifest?

@caseydavenport
Copy link
Member Author

@neiljerram yep that's right

caseydavenport added a commit that referenced this pull request Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-required Change has user-facing impact (no matter how small)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add RollingUpdate strategy to Calico DaemonSet manifests
4 participants