Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update K8s manifests with rolling upgrade for calico/node Daemonset #777

Closed
tmjd opened this issue May 10, 2017 · 3 comments
Closed

Update K8s manifests with rolling upgrade for calico/node Daemonset #777

tmjd opened this issue May 10, 2017 · 3 comments

Comments

@tmjd
Copy link
Member

tmjd commented May 10, 2017

With the rolling upgrade capability of Daemonsets in kubernetes 1.6 we can enable that in our manifests and change our Upgrade story for calico/node.

@caseydavenport
Copy link
Member

caseydavenport commented May 17, 2017

We should document how to do this, but I'm not entirely sure we want to enable the rolling-update in our checked-in manifests across the board - it should be a deliberate action on the users behalf to trigger this behavior.

EDIT: Maybe we do want to enable it. Open to hearing arguments for it :)

@caseydavenport
Copy link
Member

Let's do this in the next release. DaemonSet rolling-update support has been around long enough that I think it's safe, and is the desired behavior for most users.

@caseydavenport
Copy link
Member

Closing in favor of #1272

song-jiang pushed a commit that referenced this issue Jan 4, 2019
Add a node selector to the calicoctl manifests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants