Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Revert Gemfile changes #3132

Merged
merged 1 commit into from
Jan 22, 2024
Merged

[7.x] Revert Gemfile changes #3132

merged 1 commit into from
Jan 22, 2024

Conversation

jcoyne
Copy link
Member

@jcoyne jcoyne commented Jan 19, 2024

Reverts 74fc963

These were intended to stay local on my machine. They were a workaround for a problem I was seeing in bundler 2.5.4.

This was preventing bundler from resolving selenium-webdriver 4.9.0 for the ruby 2 builds. selenium-webdriver > 4.9 requires ruby 3.

These were intended to stay local on my machine. They were a workaround for a problem I was seeing in bundler 2.5.4
@jrochkind
Copy link
Member

jrochkind commented Jan 19, 2024

If you could link to the PR that accidentally got them into release-7.x, for good bookkeeping, I'd appreciate that!

But approved regardless!

Thank you for noticing and correcting!

@jcoyne jcoyne merged commit b360480 into release-7.x Jan 22, 2024
11 checks passed
@jcoyne jcoyne deleted the revert-workaround branch January 22, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants