-
Notifications
You must be signed in to change notification settings - Fork 70
Functional tests for atomicapp #655
base: master
Are you sure you want to change the base?
Conversation
rtnpro
commented
Mar 29, 2016
•
edited
Loading
edited
- Create base test suite
- Create base test suite for Kubernetes
- Create base test suite for Docker
- Create base test suite for Openshift
- Add tests cases for k8s provider
- Add test cases for docker provider
- Add test cases for openshift provider
This looks cool! 👯 good job so far! So out of curiosity, we're leaving the openshift/docker/k8s environments up to the user to decide :). Also when running the functional tests I hope that's it per provider instead of a |
@containscafeine Makes sense! However, if there's a bug in the library, the bug comes in testing as well. |
a1d3fb8
to
ebe6cd5
Compare
@kadel @surajssd @cdrage @containscafeine Could you have a look at the PR? The functional tests for kubernetes and docker are working, however gets stuck for the openshift, provider, the mariadb pod comes up fine, but the wordpress pod just gets stuck at |
Hmm, I have to look at it closer, but OpenShift fails to start for me :-(
k8s and docker OK |
--privileged --pid=host --net=host \ | ||
-v /:/rootfs:ro -v /var/run:/var/run:rw -v /sys:/sys -v /var/lib/docker:/var/lib/docker:rw \ | ||
-v /var/lib/origin/openshift.local.volumes:/var/lib/origin/openshift.local.volumes \ | ||
openshift/origin start""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we shouldn't use latest image. This should be latest stable version, currently openshift/origin:v1.2.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
ebe6cd5
to
e9c0731
Compare
Could you review it? |
#dotests |
Tests still seem to fail :( @rtnpro |
Are we able to add an ignore somehow or putting the functional tests in a different directory for testing? |
@cdrage the unittests failed because the test runners are trying to run the functional tests as well. We need to execute unittests using |
@rtnpro this needs to be fixed then so that travis will only run the non-functional tests, or else every PR is going to fail since it's trying to run the functional tests :) i'd advise putting the functional tests into a different folder |
On Tue, Aug 30, 2016 at 7:21 PM, Charlie Drage [email protected]
Ratnadeep Debnath, |
2e6e72c
to
d5984ee
Compare
d5984ee
to
836125e
Compare
#dotests |
1 similar comment
#dotests |
Getting this error:
|
I'm assuming this is due to failure in Debian-based OS' ^^. Mind patching in a detection if selinux is installed and/or what OS you're running? |
if getenforce == 'Enforcing': | ||
subprocess.check_output('setenforce 0', shell=True) | ||
cls._enable_selinux = True | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs to account for debian/ubuntu OS'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
836125e
to
d0b57ed
Compare
- base test suite for generic provider - base test suite for kubernetes provider.
- openshift - kubernetes
The default value is assumed to be a directory named 'nulecule-library' adjacent to the 'atomicapp' directory.
d0b57ed
to
5974a24
Compare
in functional tests.
@cdrage could you review it, once again? I am still not able to make py.test work with TTY enabled with |
@rtnpro still seems to fail upon running the tests:
endless delay at that point / freezes up. |
Also.. weird issue.. For some reason, if I run the functional tests within the atomicapp git repo |
Here is the full log running
|