Skip to content
This repository has been archived by the owner on Jan 19, 2018. It is now read-only.

Revert "Remove container on stopping on Docker provider. Fixes #389" #464

Merged
merged 1 commit into from
Dec 16, 2015

Conversation

dustymabe
Copy link
Contributor

Reverts #457

This commit doesn't work well when trying to docker stop and remove from inside a container. devicemapper will give an error. Reverting for now until we figure out what the issue is.

See comments at the end of #457

@cdrage
Copy link
Member

cdrage commented Dec 16, 2015

I can confirm that I'm getting this issue running this within a container.

lib/atomicapp/projectatomic-helloapache-a6b307fbadaa                                                                    ⍉
▶ aad stop /var/lib/atomicapp/projectatomic-helloapache-97b0e589e8e3 --provider=docker
2015-12-16 21:11:00,728 - atomicapp.plugin - WARNING - Configuration option 'providerconfig' not found
2015-12-16 21:11:00,728 - atomicapp.plugin - WARNING - Configuration option 'providerconfig' not found
2015-12-16 21:11:00,741 - docker - INFO - Undeploying to provider: Docker
2015-12-16 21:11:00,819 - docker - INFO - STOPPING AND REMOVING CONTAINER: default_centos-httpd_8295ce4f8f38
default_centos-httpd_8295ce4f8f38
Error response from daemon: Cannot destroy container default_centos-httpd_8295ce4f8f38: Driver aufs failed to remove root filesystem ce4cdd086d9b5b66db17cab088b71557af6055fb542d86baa5f804b4044c4443: rename /var/lib/docker/aufs/mnt/ce4cdd086d9b5b66db17cab088b71557af6055fb542d86baa5f804b4044c4443 /var/lib/docker/aufs/mnt/ce4cdd086d9b5b66db17cab088b71557af6055fb542d86baa5f804b4044c4443-removing: device or resource busy
FATA[0000] Error: failed to remove one or more containers 
2015-12-16 21:11:01,206 - __main__ - ERROR - Command '['docker', 'rm', 'default_centos-httpd_8295ce4f8f38']' returned non-zero exit status 1
Traceback (most recent call last):
  File "/opt/atomicapp/atomicapp/cli/main.py", line 90, in cli_stop
    nm.stop(**argdict)
  File "/opt/atomicapp/atomicapp/nulecule/main.py", line 232, in stop
    self.nulecule.stop(cli_provider, dryrun)
  File "/opt/atomicapp/atomicapp/nulecule/base.py", line 153, in stop
    component.stop(provider_key, dryrun)
  File "/opt/atomicapp/atomicapp/nulecule/base.py", line 277, in stop
    provider.undeploy()
  File "/opt/atomicapp/atomicapp/providers/docker.py", line 144, in undeploy
    subprocess.check_call(cmd)
  File "/usr/lib/python2.7/subprocess.py", line 540, in check_call
    raise CalledProcessError(retcode, cmd)
CalledProcessError: Command '['docker', 'rm', 'default_centos-httpd_8295ce4f8f38']' returned non-zero exit status 1

dustymabe added a commit that referenced this pull request Dec 16, 2015
…ontainers-on-stop

Revert "Remove container on stopping on Docker provider. Fixes #389"
@dustymabe dustymabe merged commit deddb4c into master Dec 16, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants