Marathon provider #392

kadel · 2015-11-11T13:20:52Z

fixes #357

landscape-bot · 2015-11-11T13:22:42Z

Repository health decreased by 0.05% when pulling a321284 on kadel:marathon-provider into 1c3390e on projectatomic:master.

6 new problems were found (including 0 errors and 3 code smells).
2 problems were fixed (including 0 errors and 2 code smells).

vpavlin · 2015-11-11T13:38:47Z

atomicapp/cli/main.py

@@ -165,7 +165,7 @@ def set_arguments(self):
        parser_run.add_argument(
            "--provider",
            dest="cli_provider",
-            choices=['docker', 'kubernetes', 'openshift'],
+            choices=['docker', 'kubernetes', 'openshift', 'marathon'],


Can we replace these list with a constant rather than having to update them on 2 places (run and stop)

Good point, I will do that in another PR.

cdrage · 2015-11-11T17:24:06Z

Awesome work 👍

I understand it's still a WIP, but before we merge after GA / Beta-3 I would like to see a few test examples covered in tests/units/cli/test_cli.py

rtnpro · 2015-11-12T10:21:51Z

👍 LGTM

cdrage · 2015-11-13T18:05:09Z

requirements.txt

@@ -1,3 +1,4 @@
 anymarkup==0.5.0
 lockfile==0.10.2
 jsonpointer==1.10.0
+requests==2.8.1


To note: We also changed the way that we pull requirements, so "requests" will need to be pulled from yum/apt-get/epel

landscape-bot · 2015-11-18T11:00:58Z

Repository health decreased by 0.02% when pulling dacf744 on kadel:marathon-provider into 1c3390e on projectatomic:master.

6 new problems were found (including 0 errors and 3 code smells).
2 problems were fixed (including 0 errors and 2 code smells).

landscape-bot · 2015-11-18T11:11:03Z

Repository health decreased by 1% when pulling 91826e9 on kadel:marathon-provider into 1c3390e on projectatomic:master.

8 new problems were found (including 2 errors and 3 code smells).
3 problems were fixed (including 0 errors and 3 code smells).

landscape-bot · 2015-11-18T11:40:35Z

Repository health decreased by 0.02% when pulling 764b8f1 on kadel:marathon-provider into 35952e9 on projectatomic:master.

6 new problems were found (including 0 errors and 3 code smells).
2 problems were fixed (including 0 errors and 2 code smells).

landscape-bot · 2015-11-19T10:01:46Z

Code quality remained the same when pulling 654fdb8 on kadel:marathon-provider into 35952e9 on projectatomic:master.

landscape-bot · 2015-11-24T17:59:58Z

Code quality remained the same when pulling f8a82b0 on kadel:marathon-provider into 35952e9 on projectatomic:master.

landscape-bot · 2015-11-25T13:40:28Z

Repository health increased by 0.67% when pulling b79048d on kadel:marathon-provider into 9914fe7 on projectatomic:master.

2 new problems were found (including 0 errors and 2 code smells).
6 problems were fixed (including 0 errors and 3 code smells).

landscape-bot · 2015-11-25T13:49:46Z

Code quality remained the same when pulling f8a82b0 on kadel:marathon-provider into e35080e on projectatomic:master.

kadel · 2015-12-01T10:31:23Z

what do you think @cdrage? Is it ready to be merged?

cdrage · 2015-12-01T15:26:17Z

docs/providers.md

+scheduler.
+
+This provider requires configuration (`providerapi`) to be able to connect to Marathon API. If no `providerapi` is specified it will use `http://localhost:8080` as
+Marathon API url.


~~Need docs on this, how do we pass providerapi when it's in constants.py?~~ We can provide this in answers.conf yes?

yes, you have to put it in answers.conf
something like this:

providerapi=http://10.1.2.2:8080

kadel · 2015-12-16T08:49:49Z

On one hand you are right about identifying with Mesos, but on other hand if we rename entire thing to Mesos it would be technically incorrect :-(
I will at least try mention Mesos more in docs.

kadel · 2015-12-16T08:59:17Z

About auth: Marathon alone doesn't have any authentication. It is usually run in closed environment, or some people put reverse proxy (Nginx) in front of Marathon a do HTTP Basic Auth there.
If this is case, it should be enough to set providerapi to something like this http://user:[email protected]:8080 and it should work ;-)

dharmit · 2015-12-16T09:54:27Z

Adding a bit to what @kadel already said regarding identifying with Mesos. Marathon is just one framework. You could very well use Aurora or K8s on top of Mesos to get long running jobs done. But Marathon is the most popular today. Agree about adding Mesos in the docs.

kadel · 2015-12-16T10:39:14Z

@cdrage @dustymabe I've just opened PR #463 that moves _make_request to Utils.
When it is merged I'll update this PR.

List of providers was referenced multiple times in `cli/main.py`. Moved it to a single place under `atomicapp/constants.py` to avoid updating a change at two places

Made changes to comply with pep8

when deploying composite apps artifacts from others apps gets added to this array and they are deployed again

…n artifacts

Takes care of [this comment](#392 (diff)).

test case artifact - port has to be int remove ununsed sys import

cdrage · 2015-12-16T15:32:47Z

So make_rest_request has been added to utils and docs have been updated.

Am I missing anything or is this close to be merged?

dustymabe · 2015-12-16T16:36:50Z

LGTM.

cdrage · 2015-12-16T16:54:02Z

I did one last quick check and it seems everything is in order!

✨ Congrats @kadel @dharmit !! :D Thanks for the hard work to getting this merged! ✨

Marathon provider

vpavlin reviewed Nov 11, 2015
View reviewed changes

cdrage reviewed Nov 13, 2015
View reviewed changes

cdrage mentioned this pull request Nov 18, 2015

[epic milestone] Switching to provider's API rather than direct command line. #407

Open

kadel changed the title ~~[WIP] Marathon provider~~ Marathon provider Dec 1, 2015

cdrage reviewed Dec 1, 2015
View reviewed changes

kadel and others added 20 commits December 16, 2015 15:33

first draft of marathon provider

6b67cd8

Common place for list of Providers

91925ca

List of providers was referenced multiple times in `cli/main.py`. Moved it to a single place under `atomicapp/constants.py` to avoid updating a change at two places

PEP8

113b883

Made changes to comply with pep8

change providerurl to providerapi

ef9c092

fix dry-run for marathon

b719713

empty marathon_artifacts array in init()

8bb19df

when deploying composite apps artifacts from others apps gets added to this array and they are deployed again

Adds Marathon provider data for helloapache example

ce1aca8

Nulecule for helloapache app now contains information about maratho…

a98abaf

…n artifacts

CLI tests for marathon provider using helloapache atomic app

b5a18e4

Information about where to specify providerapi for Marathon provider

d40033a

Takes care of [this comment](#392 (diff)).

Changes suggested in PR review

4036cd5

Added try..except block for request

50a321a

Catch AnyMarkupError instead of Exception for invalid artifacts

64e05d0

Use ProviderFailedException instead of sys.exit

6d7d277

marathon fixes

3f43df5

test case artifact - port has to be int remove ununsed sys import

add Marathon to list of supported providers

d134fe6

raise exeption on AnyMarkupError in Marathon provider

edf3de6

mention Mesos with Marathon in docs

dc77944

use Utils.make_rest_request in Marathon provider

0f26960

add more docs to functions in Marathon provider

22005a8

cdrage added a commit that referenced this pull request Dec 16, 2015

Merge pull request #392 from kadel/marathon-provider

e55ef71

Marathon provider

cdrage merged commit e55ef71 into projectatomic:master Dec 16, 2015

kadel deleted the marathon-provider branch December 17, 2015 08:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Marathon provider #392

Marathon provider #392

kadel commented Nov 11, 2015

landscape-bot commented Nov 11, 2015

vpavlin Nov 11, 2015

kadel Nov 11, 2015

cdrage commented Nov 11, 2015

rtnpro commented Nov 12, 2015

cdrage Nov 13, 2015

landscape-bot commented Nov 18, 2015

landscape-bot commented Nov 18, 2015

landscape-bot commented Nov 18, 2015

landscape-bot commented Nov 19, 2015

landscape-bot commented Nov 24, 2015

landscape-bot commented Nov 25, 2015

landscape-bot commented Nov 25, 2015

kadel commented Dec 1, 2015

cdrage Dec 1, 2015

kadel Dec 1, 2015

kadel commented Dec 16, 2015

kadel commented Dec 16, 2015

dharmit commented Dec 16, 2015

kadel commented Dec 16, 2015

cdrage commented Dec 16, 2015

dustymabe commented Dec 16, 2015

cdrage commented Dec 16, 2015

Marathon provider #392

Marathon provider #392

Conversation

kadel commented Nov 11, 2015

landscape-bot commented Nov 11, 2015

vpavlin Nov 11, 2015

Choose a reason for hiding this comment

kadel Nov 11, 2015

Choose a reason for hiding this comment

cdrage commented Nov 11, 2015

rtnpro commented Nov 12, 2015

cdrage Nov 13, 2015

Choose a reason for hiding this comment

landscape-bot commented Nov 18, 2015

landscape-bot commented Nov 18, 2015

landscape-bot commented Nov 18, 2015

landscape-bot commented Nov 19, 2015

landscape-bot commented Nov 24, 2015

landscape-bot commented Nov 25, 2015

landscape-bot commented Nov 25, 2015

kadel commented Dec 1, 2015

cdrage Dec 1, 2015

Choose a reason for hiding this comment

kadel Dec 1, 2015

Choose a reason for hiding this comment

kadel commented Dec 16, 2015

kadel commented Dec 16, 2015

dharmit commented Dec 16, 2015

kadel commented Dec 16, 2015

cdrage commented Dec 16, 2015

dustymabe commented Dec 16, 2015

cdrage commented Dec 16, 2015