Skip to content
This repository has been archived by the owner on Jan 19, 2018. It is now read-only.

Doc/changes to contributing.md #224

Merged
merged 2 commits into from
Aug 24, 2015
Merged

Doc/changes to contributing.md #224

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74feef8
added the requiredment for docs, in preparation of #223
goern Aug 24, 2015
3143a33
added note to implement pre-push git hook including flake8
goern Aug 24, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,15 @@ Before you submit your pull request consider the following guidelines:
```

* Create your patch, **including appropriate test cases**. Do not forget to add a copyright notice to your files, pls read along the line 625 of gpl-3.txt
* Commit your changes using a descriptive commit message.
* Include documentation that either decribe to changed behavior to an atomicapp developer or the changed capability to an end user of atomicapp.
* Commit your changes using **a descriptive commit message**.
* think about implementing a git hook, as flake8 is part of the [travis-ci tests](https://travis-ci.org/projectatomic/atomicapp) it will help you pass the CI tests.
```shell
$ cat .git/hooks/pre-push
#!/bin/bash

flake8 -v atomicapp
```
* Push your branch to GitHub:

```shell
Expand Down