This repository has been archived by the owner on Feb 7, 2023. It is now read-only.
Improve error messages in roles #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes its not easy to figure out why a test failed based on the error message. Digging into the code to find the failure comparison that caused the failure is required. Lets make the error messages more detailed when comparisons are made so triaging failures is easier. Note: This commit is only improving the error messages in the roles.
|
fedora/26/atomic failure is unrelated to this PR |
|
This looks like it will mostly address #239, right? |
Yes, I will do the actual tests next. |
|
I tried to get the I'll submit another PR for that issue, but this one is good to merge! Thanks for cleaning this up. |
mike-nguyen
added a commit
to mike-nguyen/atomic-host-tests
that referenced
this pull request
Dec 12, 2017
This is the follow on to projectatomic#288 to address projectatomic#239. projectatomic#288 addressed the error messages in the roles and this commit addresses the error messages in the tests itself.
miabbott
pushed a commit
that referenced
this pull request
Dec 12, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes its not easy to figure out why a test failed based on
the error message. Digging into the code to find the failure
comparison that caused the failure is required.
Lets make the error messages more detailed when comparisons are
made so triaging failures is easier.
Note: This commit is only improving the error messages in the roles.