Move subscription-manager auto-attach parameter in subscription file

[guillaumevincent]

subscription_data.csv.sample got an extra parameter.
We can use this extra parameter to subscribe with activationkey for example.

extra,--activationkey='...' --org='...'

If we do so, roles/redhat_subscription/tasks/main.yml:46 raise an error:

"Error: Activation keys cannot be used with --auto-attach."

Move --auto-attach in subscription file sample.
Remove --force because extra param is already set

This PR fixes #249

[rh-atomic-bot]

Can one of the admins verify this patch?
I understand the following commands:

• bot, add author to whitelist
• bot, test pull request
• bot, test pull request once

[miabbott]

@guillaumevincent If we remove the --auto-attach flag from the extra parameters, shouldn't we also have a subscription-manager attach command elsewhere in the role?

[guillaumevincent]

@miabbott my PR added the --auto-attach flag into the extra parameters. So I don't understand the question. It's the opposite.

I just allow users to remove it if like me they want to subscribe with activation key.

[guillaumevincent]

It's not visible in the pull request but extra parameters are called at the end of the command:

atomic-host-tests/roles/redhat_subscription/tasks/main.yml

Line 53 in ce4ed93

{{ lookup('csvfile', 'extra file={} default='' delimiter=,'.format(subscription_file)) }}

[miabbott]

@guillaumevincent My mistake; I don't know how I got confused like that. ¯_(ツ)_/¯

I'll have the bot run tests against this PR.

[miabbott]

bot, add author to whitelist

[guillaumevincent]

It looks like 3 builds failed because of coreos/rpm-ostree#233

Register with subscription-manager is ignored on Centos and Fedora. Only used on RHEL

[miabbott]

@guillaumevincent Unfortunately, our method of testing PRs can also uncover issues on the platforms we are testing, as we are seeing here:

• The centos/7/atomic test failed because when doing rpm-ostree install httpd, it pulls in centos-logos which wants to install /boot/grub/splash.xpm.gz. This is not currently supported in the version of rpm-ostree included in CentOS AH. See pkglayering: support packages installing into /boot coreos/rpm-ostree#853 which shows that there was a fix made only 18 days ago.

• The fedora/25/atomic failure is due to an case of a file with the unlabeled_t SELinux context. Additionally, we are phasing out testing PRs against Fedora 25, so this checkpoint will be gone in the future.

• The fedora/26/atomic failure appears to be another SELinux issue, where the test is claiming that an AVC denial was found in the journal. I don't think is is related to this PR, so we can waive this failure.

I'll put it on my todo list to checkout this PR locally and run some of my own tests just to be certain, but I'm very confident this PR will be merged in the next day or two.

[guillaumevincent]

Thanks for the update @miabbott

[miabbott]

@guillaumevincent I ran this PR locally against RHEL, Fedora 26, and CentOS AH Continuous without trouble. Thanks for the patience!