-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hv: align the MAX_IR_ENRIES to MAX_PT_IRQ_ENTRIES #6746
Conversation
The CONFIG_MAX_IR_ENTRIES and CONFIG_MAX_PT_IRQ_ENTRIES are separate configuration items, and they can be configured through configuration tool When the number of PT irq entries are more than IR entries, then some passthrough devices' irqs may failed to be protected by interrupt remapping or automatically injected by post-interrupt mechanism. And it waste memory if the CONFIG_MAX_IR_ENTRIES is larger. This patch replace the CONFIG_MAX_IR_ENTRIES to MAX_IR_ENTRIES and enforce it equal to CONFIG_PT_IRQ_ENTRIES. This way can enforce all PT irqs works with IR or PI mechanism. Tracked-On: projectacrn#6745 Signed-off-by: Chenli Wei <[email protected]> Acked-by: Eddie Dong <[email protected]> Reviewed-by: Wang, Yu1 <[email protected]>
OK to verify |
5 similar comments
OK to verify |
OK to verify |
OK to verify |
OK to verify |
OK to verify |
try verify EHL |
try verify ldra |
OK to verify doc |
try verify ldra |
No new violations to the coding guideline detected. |
OK to verify |
try verify EHL |
@weichenli-intel
|
OK to verify |
OK to verify |
try verify EHL |
I am fine with 1st patch, but not sure on the 2nd one. |
This reverts commit bf57505.
The CONFIG_MAX_IR_ENTRIES and CONFIG_MAX_PT_IRQ_ENTRIES are separate configuration items, and they can be configured through configuration tool When the number of PT irq entries are more than IR entries, then some passthrough devices' irqs may failed to be protected by interrupt remapping or automatically injected by post-interrupt mechanism. And it waste memory if the CONFIG_MAX_IR_ENTRIES is larger. This patch replace the CONFIG_MAX_IR_ENTRIES to MAX_IR_ENTRIES and enforce it align to CONFIG_PT_IRQ_ENTRIES and round up to > 2^n as the IRTA_REG spec.This way can enforce all PT irqs works with IR or PI mechanism. Tracked-On: projectacrn#6745 Signed-off-by: Chenli Wei <[email protected]> Acked-by: Eddie Dong <[email protected]> Reviewed-by: Wang, Yu1 <[email protected]>
No new violations to the coding guideline detected. |
update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This series is bad. We shouldn;t include that many patches
The CONFIG_MAX_IR_ENTRIES and CONFIG_MAX_PT_IRQ_ENTRIES are separate
configuration items, and they can be configured through configuration tool
When the number of PT irq entries are more than IR entries, then some
passthrough devices' irqs may failed to be protected by interrupt
remapping or automatically injected by post-interrupt mechanism.
And it waste memory if the CONFIG_MAX_IR_ENTRIES is larger.
This patch replace the CONFIG_MAX_IR_ENTRIES to MAX_IR_ENTRIES and
enforce it equal to CONFIG_PT_IRQ_ENTRIES. This way can enforce all PT
irqs works with IR or PI mechanism.
Tracked-On: #6745
Signed-off-by: Chenli Wei [email protected]
Acked-by: Eddie Dong [email protected]
Reviewed-by: Wang, Yu1 [email protected]