-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sunbird CDN configuration #3594
Sunbird CDN configuration #3594
Conversation
@keshavprasadms |
|
@keshavprasadms |
AZURE_BLOB_STORE_ACCOUNT_NAME={{sunbird_private_storage_account_name}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@surabhi-mahawar Are these variable still required? Below is another variable which has same contents
SUNBIRD_CLOUD_MEDIA_STORAGE_KEY
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@keshavprasadms
No this is not required not, I have removed these variables from the files
@surabhi-mahawar This PR is supporting only Azure cloud right? In the description, I can see AWS support also, but I am unable to find the corresponding AWS cloud variables in the PR. |
@keshavprasadms The sunbird cloud agnostic tool should handle this according to the SUNBIRD_CLOUD_MEDIA_STORAGE_TYPE mentioned, if this changes to AWS, the credentials for it should be added in SUNBIRD_CLOUD_MEDIA_STORAGE_KEY, SUNBIRD_CLOUD_MEDIA_STORAGE_SECRET as well. Or can there be a case where different instances can have different CDNs ? |
@surabhi-mahawar Please can you connect with @santhosh-tg for this? He is driving a change across all BB's to standardize the variable names and the naming convention, how to support multiple clouds etc. A brief discussion with him would help you get clarity and take this PR forward. Would be good if you can please setup a call and discuss with the team - @santhosh-tg @gandham-santhosh |
@keshavprasadms CC: @ChakshuGautam |
I don't think adding email id's here is a good idea due to privacy concerns. As @ChakshuGautam is already on Slack, you can easily get in touch with the folks. These are the slack handlers
|
@keshavprasadms CC: @ChakshuGautam |
Jira ticket: SB-31158
Description: This PR includes the environment variables required for sunbird cloud agnostic tool. We have added conditions to use this tool or other services based on the configuration. This tool provides option to use AWS/Azure etc which will also be handled via sunbird confirguation variables SUNBIRD_CLOUD_MEDIA_STORAGE_TYPE.
We intend to store all the media files(Image/Audio/Video/Document) being used in UCI assessment bot. Also use this to display media files as well.
If these configuration is not set, it will start the service but will just show error message in the service logs and will not respond to that particular media related message.