Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering issue with fullscreened applications #71

Closed
sodface opened this issue Jan 8, 2024 · 8 comments
Closed

Rendering issue with fullscreened applications #71

sodface opened this issue Jan 8, 2024 · 8 comments

Comments

@sodface
Copy link

sodface commented Jan 8, 2024

Hi, running the latest development branch so I'm not sure if this occurs on previous versions, but I noticed when going fullscreen with mpv (key f or double click) or firefox (F11) the window rendering gets wonky.

This can be fixed by just re-selecting the workspace.

This does not occur with a single monitor. On my dual monitor desktop, it's as if the application thinks it needs to span the combined resolution of both monitors when first entering fullscreen mode. After re-selecting the workspace it redraws correctly.

With firefox for example, pressing F11 takes you from screenshot 1 to screenshot 2:

20240108_07h53m02s_grim

20240108_07h53m11s_grim

mpv behaves similarly:

20240108_07h47m56s_grim

20240108_07h48m05s_grim

@project-repo
Copy link
Owner

Thanks for the bug report! I think we were able to locate the issue,
could you try out the latest commits on the development branch?
Cheers,
project-repo

@sodface
Copy link
Author

sodface commented Jan 8, 2024

That does seem to fix the fullscreen issue but it causes my desktop layout to be left(2) <-- right(1) even with config:

output HDMI-A-1 prio 1
output HDMI-A-1 permanent
output HDMI-A-2 permanent

I tried commenting out the config too but the result was the same.

@sodface
Copy link
Author

sodface commented Jan 10, 2024

If it helps, I went back a few commits in the development branch and skipped most of the ones that I thought weren't relevant to functionality.

This commit affects my layout as noted in the above comment:
4b4f6d4

This commit is working ok:
3da0198

@sodface
Copy link
Author

sodface commented Jan 11, 2024

Sorry, correction:

Launching this commit from tty just crashes back to tty:
4b4f6d4

This commit launches ok but the dual monitor layout is incorrect:
99b643a

Layout is correct with this commit:
3da0198

@project-repo
Copy link
Owner

Hi sodface

Sorry for not getting back sooner... Thanks for the bisect though, could
you give the latest commit on development a spin? Does that change
anything?

Cheers
project-repo

@sodface
Copy link
Author

sodface commented Jan 11, 2024

Quick test since I'm heading out but it looks good, thanks!

@sodface
Copy link
Author

sodface commented Jan 26, 2024

This can be closed too correct? 2.3.0 works well.

@project-repo
Copy link
Owner

Fixed with 2.3.0

Closing.

cheers
project-repo

project-repo pushed a commit that referenced this issue Jan 27, 2024
project-repo pushed a commit that referenced this issue Jan 27, 2024
  * Unbreak build on FreeBSD (#74, 73 in Bugs.md)
    * Thanks to Jan Beich for pointing this out.
  * Add Issue 74 to Bugs.md (#71, was fixed in 2.3.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants