Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert trino_schema_prefix #5477

Merged
merged 4 commits into from
Jan 30, 2025
Merged

revert trino_schema_prefix #5477

merged 4 commits into from
Jan 30, 2025

Conversation

maskarb
Copy link
Member

@maskarb maskarb commented Jan 30, 2025

Description

The trino_schema_prefix was intended to be used within a shared data catalog so that we could limit our policy to only access the prefixed databases. Since we plan to utilize our own separate catalog, this is no longer necessary to implement.

Testing

  1. smokes

Release Notes

  • proposed release note
* revert trino_schema_prefix

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.1%. Comparing base (3dbeb6d) to head (d179047).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #5477   +/-   ##
=====================================
  Coverage   94.1%   94.1%           
=====================================
  Files        371     371           
  Lines      31635   31624   -11     
  Branches    3389    3387    -2     
=====================================
- Hits       29773   29763   -10     
  Misses      1211    1211           
+ Partials     651     650    -1     

@maskarb maskarb added the smoke-tests pr_check will build the image and run minimal required smokes label Jan 30, 2025
@maskarb maskarb marked this pull request as ready for review January 30, 2025 17:16
@maskarb maskarb requested review from a team as code owners January 30, 2025 17:16
@maskarb maskarb merged commit 39c7aaa into main Jan 30, 2025
14 checks passed
@maskarb maskarb deleted the revert-schema-prefix branch January 30, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
smoke-tests pr_check will build the image and run minimal required smokes smokes-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants