adding year month to disk join where clause #5443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcouzens
added
the
hot-fix-smoke-tests
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5443 +/- ##
=====================================
Coverage 94.2% 94.2%
=====================================
Files 370 370
Lines 31539 31539
Branches 3378 3378
=====================================
Hits 29698 29698
Misses 1197 1197
Partials 644 644 |
maskarb
previously approved these changes
Jan 13, 2025
lcouzens
added
smoke-tests
|
/retest |
maskarb
previously approved these changes
Jan 13, 2025
maskarb
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
COST-####
Description
This change will add the missing where clause for year month when joining the disk capacities temp table.
This change also reverts #5442
Testing
Release Notes