Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHCLOUD-36497] - switch error messages from sources to integrations #5407

Merged
merged 3 commits into from
Nov 27, 2024

Conversation

lcouzens
Copy link
Contributor

Jira Ticket

RHCLOUD-36497

Description

The UI team has spotted an error message that makes a reference to "sources" instead of integrations, which would confuse users and customers.

Testing

  1. Checkout Branch
  2. Restart Koku
  3. Hit endpoint or launch shell
    1. You should see ...
  4. Do more things...

Release Notes

  • proposed release note
* [RHCLOUD-36497](https://issues.redhat.com/browse/RHCLOUD-36497) Replace "sources" references with "integrations" in feedback messages

@lcouzens lcouzens added the smoke-tests pr_check will build the image and run minimal required smokes label Nov 27, 2024
@lcouzens lcouzens marked this pull request as ready for review November 27, 2024 13:24
@lcouzens lcouzens requested review from a team as code owners November 27, 2024 13:24
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.1%. Comparing base (45942c7) to head (3e0a1f6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #5407   +/-   ##
=====================================
  Coverage   94.1%   94.1%           
=====================================
  Files        371     371           
  Lines      31542   31542           
  Branches    3380    3380           
=====================================
  Hits       29691   29691           
  Misses      1200    1200           
  Partials     651     651           

@lcouzens lcouzens enabled auto-merge (squash) November 27, 2024 14:40
@lcouzens lcouzens added hot-fix-smoke-tests pr_check label to run minimal smoke tests for fast moving bug-fix and removed smoke-tests pr_check will build the image and run minimal required smokes labels Nov 27, 2024
@lcouzens
Copy link
Contributor Author

lcouzens commented Nov 27, 2024

/retest

1 similar comment
@lcouzens
Copy link
Contributor Author

/retest

@lcouzens lcouzens merged commit ab5e65d into main Nov 27, 2024
14 checks passed
@lcouzens lcouzens deleted the RHCLOUD-36497-integrations branch November 27, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hot-fix-smoke-tests pr_check label to run minimal smoke tests for fast moving bug-fix smokes-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants