Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COST-5711] - Add new middleware access check #5400

Merged
merged 2 commits into from
Nov 26, 2024
Merged

[COST-5711] - Add new middleware access check #5400

merged 2 commits into from
Nov 26, 2024

Conversation

lcouzens
Copy link
Contributor

Jira Ticket

COST-5711

Description

This change will add an additional check to allow un-authenticated users access to s3-regions for populating the UI regions list.

Testing

  1. Checkout Branch
  2. Restart Koku
  3. Hit endpoint or launch shell
    1. You should see ...
  4. Do more things...

Release Notes

  • proposed release note
* [COST-5711#](https://issues.redhat.com/browse/COST-5711) Fix middleware Allow All access on s3-regions endpoint

@lcouzens lcouzens added the hot-fix-smoke-tests pr_check label to run minimal smoke tests for fast moving bug-fix label Nov 26, 2024
@lcouzens lcouzens requested review from a team as code owners November 26, 2024 15:27
Copy link
Contributor

@chambridge chambridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.1%. Comparing base (b8af477) to head (11ecce7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #5400   +/-   ##
=====================================
  Coverage   94.1%   94.1%           
=====================================
  Files        371     371           
  Lines      31563   31569    +6     
  Branches    3388    3389    +1     
=====================================
+ Hits       29701   29709    +8     
+ Misses      1205    1204    -1     
+ Partials     657     656    -1     

@lcouzens lcouzens enabled auto-merge (squash) November 26, 2024 16:11
@lcouzens lcouzens merged commit a53b35f into main Nov 26, 2024
14 checks passed
@lcouzens lcouzens deleted the COST-5711 branch November 26, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hot-fix-smoke-tests pr_check label to run minimal smoke tests for fast moving bug-fix smokes-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants