-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[COST-5657] subs: use subquery in Trino to join from Postgres #5381
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5381 +/- ##
=====================================
Coverage 94.1% 94.1%
=====================================
Files 371 371
Lines 31557 31552 -5
Branches 3385 3385
=====================================
- Hits 29686 29684 -2
+ Misses 1210 1209 -1
+ Partials 661 659 -2 |
We likely have the same problem with the Instead we could just build the exclude resource id list in trino, then left join in the excluded list and a filter to make sure all of our excluded resources are not included in the return:
This will allow for the excludes resource ids to be however long it needs to be without changing the length of the query itself. |
/retest |
@myersCody good suggestion. I had not considered making Trino do the postgres query, so that's a good idea! |
Jira Ticket
COST-5657
Description
This change will filter the list of resource-ids thru a subquery in postgres.
Testing
Release Notes