Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up default time scope logic #5366

Merged
merged 9 commits into from
Nov 18, 2024
Merged

Clean up default time scope logic #5366

merged 9 commits into from
Nov 18, 2024

Conversation

myersCody
Copy link
Contributor

Jira Ticket

Description

This change will simplify the default time scope logic

Testing

Smoke tests pass

Release Notes

  • proposed release note
* [COST-####](https://issues.redhat.com/browse/COST-####) Fix some things

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.1%. Comparing base (f34dd6b) to head (21f98a3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #5366   +/-   ##
=====================================
  Coverage   94.1%   94.1%           
=====================================
  Files        371     371           
  Lines      31552   31547    -5     
  Branches    3385    3384    -1     
=====================================
- Hits       29681   29677    -4     
+ Misses      1212    1210    -2     
- Partials     659     660    +1     
---- 🚨 Try these New Features:

@myersCody myersCody mentioned this pull request Nov 11, 2024
1 task
@myersCody myersCody added the smoke-tests pr_check will build the image and run minimal required smokes label Nov 11, 2024
@myersCody
Copy link
Contributor Author

/retest

@myersCody myersCody marked this pull request as ready for review November 12, 2024 20:46
@myersCody myersCody requested review from a team as code owners November 12, 2024 20:46
@myersCody myersCody enabled auto-merge (squash) November 14, 2024 14:13
@myersCody myersCody disabled auto-merge November 14, 2024 14:13
@myersCody myersCody enabled auto-merge (squash) November 14, 2024 14:13
@myersCody
Copy link
Contributor Author

/retest

@myersCody myersCody merged commit 3fb15b9 into main Nov 18, 2024
14 checks passed
@myersCody myersCody deleted the ec2_default_scope branch November 18, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
smoke-tests pr_check will build the image and run minimal required smokes smokes-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants