Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COST-5385] Update Trino and Hive images #5258

Merged
merged 4 commits into from
Aug 14, 2024

Conversation

samdoran
Copy link
Contributor

@samdoran samdoran commented Aug 9, 2024

Jira Ticket

COST-5385

Description

Use newer Trino and Hive images.

Testing

  1. Checkout Branch
  2. make docker-up-min
  3. In the Trino CLI, run SELECT version();

Release Notes

  • proposed release note
* [COST-5385](https://issues.redhat.com/browse/COST-5385) Update Trino and Hive container images

@samdoran samdoran added the smoke-tests pr_check will build the image and run minimal required smokes label Aug 9, 2024
@samdoran samdoran requested review from a team as code owners August 9, 2024 16:40
@maskarb
Copy link
Member

maskarb commented Aug 9, 2024

  1. This PR does not need smokes
  2. the jvm.config needs to be updated to include:
-XX:G1NumCollectionsKeepPinned=10000000

djnakabaale
djnakabaale previously approved these changes Aug 9, 2024
@samdoran samdoran removed the smoke-tests pr_check will build the image and run minimal required smokes label Aug 9, 2024
@samdoran
Copy link
Contributor Author

samdoran commented Aug 9, 2024

@maskarb What does the NumCollectionsKeepPinned G1GC option do? I wanted to add a comment about its purpose but I am not finding that in documentation anywhere.

@samdoran samdoran force-pushed the COST-5385/update-trino-hive-images branch from f71a9e5 to 6ea86f6 Compare August 9, 2024 19:42
@samdoran samdoran force-pushed the COST-5385/update-trino-hive-images branch from 6ea86f6 to 32aae5d Compare August 12, 2024 18:19
@maskarb
Copy link
Member

maskarb commented Aug 13, 2024

@samdoran no idea. Trino would not start without it:
https://github.com/trinodb/trino/blob/master/core/trino-main/src/main/java/io/trino/server/TrinoSystemRequirements.java#L140

@samdoran samdoran enabled auto-merge (squash) August 14, 2024 14:30
@samdoran samdoran merged commit a86218d into main Aug 14, 2024
11 checks passed
@samdoran samdoran deleted the COST-5385/update-trino-hive-images branch August 14, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants