Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COST-5367] - Fix Azure ingress required columns #5244

Merged
merged 3 commits into from
Aug 5, 2024
Merged

[COST-5367] - Fix Azure ingress required columns #5244

merged 3 commits into from
Aug 5, 2024

Conversation

lcouzens
Copy link
Contributor

@lcouzens lcouzens commented Aug 2, 2024

Jira Ticket

COST-5367

Description

This change will update the required columns for the Azure customer filtered data flow. Azure report columns come in many different formats WRT case sensitivity. This change consolidates the required columns and validates them all in lower case. Additionally this goes hand in hand with the script updates for RHEL metering in project-koku/koku-data-selector#39 that PR calls out the case restriction and updates the script to normalise them.

Testing

  1. Checkout Branch
  2. Restart Koku
  3. Add storage only Azure source (customer filtered flow) [Luke can help here, there is also some helpful scripts on Inscope]
  4. Send an Azure ingress payload with required columns
  5. Processing should complete successfully
  6. Send a second Azure payload with missing columns
  7. Should see an error message raised with missing columns listed.

Release Notes

  • proposed release note
* [COST-5367](https://issues.redhat.com/browse/COST-5367) Fix Azure ingress required columns

Notes

This may require some IQE test updates specifically test_api_azure_hcs_customer_filtered_report

@lcouzens lcouzens requested review from a team as code owners August 2, 2024 18:18
@lcouzens lcouzens added the smoke-tests pr_check will build the image and run minimal required smokes label Aug 2, 2024
@lcouzens lcouzens added full-run-smoke-tests pr_check will build the image and run all smoke tests and removed smoke-tests pr_check will build the image and run minimal required smokes labels Aug 5, 2024
@lcouzens
Copy link
Contributor Author

lcouzens commented Aug 5, 2024

Full smokes passed!!

@lcouzens lcouzens added smoke-tests pr_check will build the image and run minimal required smokes and removed full-run-smoke-tests pr_check will build the image and run all smoke tests labels Aug 5, 2024
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.1%. Comparing base (fcfbe8b) to head (f33e15a).

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #5244     +/-   ##
=======================================
- Coverage   94.1%   94.1%   -0.0%     
=======================================
  Files        375     375             
  Lines      31412   31410      -2     
  Branches    4623    4623             
=======================================
- Hits       29552   29548      -4     
- Misses      1185    1186      +1     
- Partials     675     676      +1     

@lcouzens
Copy link
Contributor Author

lcouzens commented Aug 5, 2024

/retest

@lcouzens lcouzens merged commit 3d79211 into main Aug 5, 2024
11 checks passed
@lcouzens lcouzens deleted the COST-5367 branch August 5, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
smoke-tests pr_check will build the image and run minimal required smokes smokes-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants