Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COST-4993] gate ec2 endpoint with unleash #5229

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Conversation

maskarb
Copy link
Member

@maskarb maskarb commented Jul 22, 2024

Jira Ticket

COST-4993

Description

This change will use the is_feature_cost_4403_ec2_compute_cost_enabled feature flag to gate the API response.

Testing

  1. start koku with gunicorn:
$ RUN_GUNICORN=True docker compose up koku-server
  1. in unleash, clone the cost-management.backend.schema-flag-template -> cost-management.backend.feature-4403-enable-ec2-compute-processing
  2. delete redis cache:
$ make delete-redis-cache
  1. visit http://localhost:8000/api/cost-management/v1/reports/aws/resources/ec2-compute/?filter[operating_system]=10 and see a response
  2. in unleash, set the rollout % to 0%. Wait a few minutes
  3. delete redis-cache:
$ make delete-redis-cache
  1. visit http://localhost:8000/api/cost-management/v1/reports/aws/resources/ec2-compute/?filter[operating_system]=10 again and this time see a 404 Not Found response:
{
    "errors": [
        {
            "detail": "Not found.",
            "source": "detail",
            "status": 404
        }
    ]
}

Release Notes

  • proposed release note
* [COST-4993](https://issues.redhat.com/browse/COST-4993) gate EC2 endpoint with unleash flag

@maskarb maskarb requested review from a team as code owners July 22, 2024 16:43
@maskarb maskarb added the smoke-tests pr_check will build the image and run minimal required smokes label Jul 22, 2024
@maskarb
Copy link
Member Author

maskarb commented Jul 22, 2024

/retest

Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.1%. Comparing base (7aad9f8) to head (f3f1dae).

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #5229     +/-   ##
=======================================
- Coverage   94.1%   94.1%   -0.0%     
=======================================
  Files        373     373             
  Lines      31130   31136      +6     
  Branches    4573    4574      +1     
=======================================
+ Hits       29301   29305      +4     
- Misses      1164    1165      +1     
- Partials     665     666      +1     

@maskarb maskarb enabled auto-merge (squash) July 22, 2024 17:17
@maskarb maskarb merged commit 6ffdd28 into main Jul 22, 2024
11 checks passed
@maskarb maskarb deleted the cost-4993-gate-api branch July 22, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
smoke-tests pr_check will build the image and run minimal required smokes smokes-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants