Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[COST-5280] - rename cpu/memory request/limits parameters #5226

Merged
merged 1 commit into from
Jul 19, 2024
Merged

[COST-5280] - rename cpu/memory request/limits parameters #5226

merged 1 commit into from
Jul 19, 2024

Conversation

maskarb
Copy link
Member

@maskarb maskarb commented Jul 19, 2024

Jira Ticket

COST-5280

Description

This change will rename cpu/memory request/limits params.

Testing

  1. smokes

Release Notes

  • proposed release note
* [[COST-5280](https://issues.redhat.com/browse/COST-5280)] rename cpu/memory request/limits parameters

@maskarb maskarb added the smoke-tests pr_check will build the image and run minimal required smokes label Jul 19, 2024
@maskarb maskarb requested review from a team as code owners July 19, 2024 14:54
@maskarb maskarb changed the title [COST-5280] - rename params [COST-5280] - rename cpu/memory request/limits parameters Jul 19, 2024
djnakabaale
djnakabaale approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@djnakabaale djnakabaale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍🏾

@maskarb maskarb merged commit c93cf97 into main Jul 19, 2024
11 checks passed
@maskarb maskarb deleted the COST-5280-rename branch July 19, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djnakabaale djnakabaale djnakabaale approved these changes

Assignees
No one assigned
Labels
smoke-tests pr_check will build the image and run minimal required smokes smokes-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maskarb @djnakabaale