Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nise and AWS DataTransferGenerator resource IDs #5222

Merged
merged 4 commits into from
Jul 18, 2024
Merged

Conversation

samdoran
Copy link
Contributor

@samdoran samdoran commented Jul 18, 2024

Jira Ticket

COST-3761

Description

Update nise to make the AWS DataTransferGenerator resource_id field behave the same as th EC2 Generator resource_id field. Update the nise YAML file to match the new behavior.

Related nise change: project-koku/nise#518

Testing

  1. Checkout Branch
  2. Restart Koku
  3. Create a customer and load AWS data
make create-test-customer
make load-test-customer-data test_source=aws
  1. Verify the Data Transfer resource IDs look correct
trino:org1234567> SELECT distinct lineitem_resourceid, product_sku, product_productfamily FROM aws_line_items WHERE lineitem_productcode = 'AmazonEC2';

Release Notes

  • proposed release note
* Update `nise` and YAML file to use correct resource_id format for AWS Data Transfer Generators

@samdoran samdoran requested review from a team as code owners July 18, 2024 16:07
@samdoran samdoran added the hot-fix-smoke-tests pr_check label to run minimal smoke tests for fast moving bug-fix label Jul 18, 2024
@samdoran
Copy link
Contributor Author

/retest

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.1%. Comparing base (0d7c445) to head (dd29a6e).

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #5222     +/-   ##
=======================================
- Coverage   94.1%   94.1%   -0.0%     
=======================================
  Files        373     373             
  Lines      31040   31040             
  Branches    4564    4564             
=======================================
- Hits       29214   29213      -1     
- Misses      1162    1164      +2     
+ Partials     664     663      -1     

@lcouzens
Copy link
Contributor

/retest

@samdoran samdoran enabled auto-merge (squash) July 18, 2024 17:57
@samdoran samdoran merged commit b81c9fa into main Jul 18, 2024
11 checks passed
@samdoran samdoran deleted the update-nise branch July 18, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hot-fix-smoke-tests pr_check label to run minimal smoke tests for fast moving bug-fix smokes-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants