-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[COST-4620] - Add basic provider data validation #5218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcouzens
added
smoke-tests
pr_check will build the image and run minimal required smokes
and removed
smoke-tests
pr_check will build the image and run minimal required smokes
labels
Jul 17, 2024
lcouzens
added
the
smoke-tests
pr_check will build the image and run minimal required smokes
label
Jul 22, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5218 +/- ##
=======================================
- Coverage 94.1% 94.1% -0.0%
=======================================
Files 373 375 +2
Lines 31226 31412 +186
Branches 4593 4623 +30
=======================================
+ Hits 29379 29549 +170
- Misses 1177 1185 +8
- Partials 670 678 +8 |
lcouzens
commented
Jul 23, 2024
lcouzens
commented
Jul 25, 2024
djnakabaale
reviewed
Aug 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here some feedback on a couple things noticed:
lcouzens
commented
Aug 1, 2024
djnakabaale
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
COST-4620
Description
Testing
is_validation_enabled
http://localhost:5042/api/cost-management/v1/validate_cost_data/?provider_uuid={uuid}&start_date=2024-07-01&end_date=2024-07-16
Testing invalid data
update org1234567.reporting_awscostentrylineitem_daily_summary set unblended_cost = 0 where product_code = 'AmazonEC2';
Testing OCP on Cloud clusters
Testing via masu
http://localhost:5042/api/cost-management/v1/validate_cost_data/?provider_uuid={provider_uuid}&start_date=2024-07-01&end_date=2024-07-19
(Sub your provider ID)Testing an OCP on CLOUD cluster via masu
http://localhost:5042/api/cost-management/v1/validate_cost_data/?provider_uuid={provider_uuid}&ocp_on_cloud_type={type}&start_date=2024-07-01&end_date=2024-07-19
(Sub your provider ID)Notes:
Along side the testing about if you want to verify the query data you can enable
DEBUG
logs and you should see the comparison data from Trino/PG logged for quick comparison.Example: [2024-07-22 12:45:54,311] INFO fc9a26e0-a60a-4264-8aac-afebb4f082e5 3268 PG: {datetime.date(2024, 7, 18): 3870.034663868, datetime.date(2024, 7, 19): 3670.98312068} Trino data: {datetime.date(2024, 7, 18): 3870.034663795944, datetime.date(2024, 7, 19): 3670.9831205979876}
Release Notes