Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate local volume mounts #5215

Merged
merged 4 commits into from
Jul 19, 2024
Merged

Consolidate local volume mounts #5215

merged 4 commits into from
Jul 19, 2024

Conversation

maskarb
Copy link
Member

@maskarb maskarb commented Jul 12, 2024

Description

This change will further consolidate volume mounts into the dev/containers directory. This PR moves the pg_data into dev/containers/postgresql/data, the minio data (which is currently in .trino/parquet_data) into dev/containers/minio, and the trino data and logs into dev/containers/trino/data and dev/containers/trino/logs, respectively.

Release Notes

  • proposed release note
* Consolidate local volume mounts

@maskarb maskarb force-pushed the some-trino-docker-updates branch from 829bf30 to 5e34539 Compare July 12, 2024 17:41
@maskarb maskarb changed the title move trino/minio volumes to dev/containers Consolidate local volume mounts Jul 12, 2024
@maskarb maskarb marked this pull request as ready for review July 12, 2024 17:56
@maskarb maskarb requested review from a team as code owners July 12, 2024 17:56
Copy link
Contributor

@samdoran samdoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Much cleaner.

@maskarb maskarb enabled auto-merge (squash) July 19, 2024 13:04
@maskarb maskarb merged commit dc1b7f8 into main Jul 19, 2024
11 checks passed
@maskarb maskarb deleted the some-trino-docker-updates branch July 19, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants