-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[COST-5114] Add type ahead support for the new EC2 fields #5159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5159 +/- ##
=====================================
Coverage 94.1% 94.1%
=====================================
Files 371 373 +2
Lines 30941 31023 +82
Branches 4545 4559 +14
=====================================
+ Hits 29114 29195 +81
+ Misses 1166 1165 -1
- Partials 661 663 +2 |
samdoran
reviewed
Jul 11, 2024
address pr feedback
lcouzens
reviewed
Jul 16, 2024
lcouzens
reviewed
Jul 16, 2024
lcouzens
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
COST-5114
Description
This change add type ahead support for the new EC2 fields:
resource_id
,instance_name
,operating_system
.Testing
Checkout Branch
Load test data
On these endpoints (supported filters are
seacrh
andlimit
), check to see:the AWS EC2 compute instances,
http://127.0.0.1:8000/api/cost-management/v1/resource-types/aws-ec2-compute-instances/?search=instance&limit=4
the AWS EC2 compute operating systems,
http://127.0.0.1:8000/api/cost-management/v1/resource-types/aws-ec2-compute-os/?search=Linux
Release Notes