Use newer API version for Azure Cost Management client #5158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SDK defaults to using 2022-10-01 and there is a bug with the Azure API not properly returning data for V2 cost exports. Hopefully using the newer Azure API will work aruond the problem while Microsoft fixes the bug on their end.
samdoran
added
the
azure-smoke-tests
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5158 +/- ##
=======================================
- Coverage 94.1% 94.1% -0.0%
=======================================
Files 375 375
Lines 31193 31194 +1
Branches 3727 3727
=======================================
- Hits 29361 29360 -1
- Misses 1167 1168 +1
- Partials 665 666 +1 |
lcouzens
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
COST-5113
Description
The SDK defaults to using 2022-10-01 and there is a bug with the Azure API not properly returning data for V2 cost exports. Hopefully using the newer Azure API will work aruond the problem while Microsoft fixes the bug on their end.
Testing
Release Notes