-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[COST-5093] Update mapped tags in EC2 summary table #5147
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5147 +/- ##
=====================================
Coverage 94.1% 94.1%
=====================================
Files 371 371
Lines 30927 30929 +2
Branches 4542 4542
=====================================
+ Hits 29103 29105 +2
Misses 1163 1163
Partials 661 661 |
djnakabaale
added
the
smoke-tests
pr_check will build the image and run minimal required smokes
label
Jun 5, 2024
/retest |
bacciotti
reviewed
Jun 6, 2024
bacciotti
reviewed
Jun 6, 2024
bacciotti
reviewed
Jun 6, 2024
samdoran
reviewed
Jul 11, 2024
samdoran
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
COST-5093
Description
This change will update mapped tags for EC2 summary table by leveraging the existing update functionality for the aws daily summary table.
Testing
Checkout Branch
Load test data
Create tag mappings with a
PUT
request to this endpoint and requires knowing tag uuids.Check these endpoints to
see the parent mapped tags,
http://127.0.0.1:8000/api/cost-management/v1/settings/tags/mappings/parent/?source_type=AWS
see mapped child tags,
http://127.0.0.1:8000/api/cost-management/v1/settings/tags/mappings/child/
Trigger a re-summary for the AWS source
Then in the postgres shell, check to see that tags are updated in the EC2 table