Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COST-5030] - Removal of special case namespace tag matching #5142

Merged
merged 3 commits into from
May 31, 2024

Conversation

lcouzens
Copy link
Contributor

@lcouzens lcouzens commented May 31, 2024

Jira Ticket

COST-5030

Description

This change will remove namespace from the special tag matching sql for OCP on AWS. This was originally added for the internal RH account but is no longer needed.

Testing

  1. Checkout Branch
  2. Restart Koku
  3. Hit endpoint or launch shell
    1. You should see ...
  4. Do more things...

Release Notes

  • [ x] proposed release note
* [COST-5030](https://issues.redhat.com/browse/COST-5030) Removal of namespace special tag matching (internal)

@lcouzens lcouzens added the aws-smoke-tests pr_check will build the image and run aws + ocp on aws smoke tests label May 31, 2024
@lcouzens lcouzens changed the title [COST-5030] - Add special case tag to pandas matching [COST-5030] - Add namepsace to special case ocp/aws tag matching May 31, 2024
@lcouzens lcouzens marked this pull request as ready for review May 31, 2024 11:08
@lcouzens lcouzens requested review from a team as code owners May 31, 2024 11:08
Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.1%. Comparing base (541f699) to head (2ec96a7).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #5142   +/-   ##
=====================================
  Coverage   94.1%   94.1%           
=====================================
  Files        375     375           
  Lines      31170   31170           
  Branches    3730    3730           
=====================================
+ Hits       29321   29323    +2     
+ Misses      1180    1179    -1     
+ Partials     669     668    -1     

@lcouzens lcouzens changed the title [COST-5030] - Add namepsace to special case ocp/aws tag matching [COST-5030] - Removal of special case namespace tag matching May 31, 2024
@esebesto
Copy link
Contributor

The test failures are every-other-last-of-the-month issue, unrelated to PR changes.

@lcouzens lcouzens enabled auto-merge (squash) May 31, 2024 13:56
auto-merge was automatically disabled May 31, 2024 13:58

Base branch was modified

@lcouzens lcouzens added hot-fix-smoke-tests pr_check label to run minimal smoke tests for fast moving bug-fix and removed aws-smoke-tests pr_check will build the image and run aws + ocp on aws smoke tests labels May 31, 2024
@lcouzens lcouzens merged commit 7f8cb20 into main May 31, 2024
11 checks passed
@lcouzens lcouzens deleted the COST-5030-special-case-labels branch May 31, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hot-fix-smoke-tests pr_check label to run minimal smoke tests for fast moving bug-fix smokes-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants