[COST-4906] Update resource matching to use CSI volume handle #5132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
myersCody
added
azure-smoke-tests
|
/retest |
lcouzens
previously approved these changes
May 29, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5132 +/- ##
=======================================
- Coverage 94.1% 94.1% -0.0%
=======================================
Files 376 376
Lines 31308 31317 +9
Branches 3756 3759 +3
=======================================
+ Hits 29467 29471 +4
- Misses 1173 1177 +4
- Partials 668 669 +1 |
samdoran
reviewed
May 29, 2024
Co-authored-by: Sam Doran <[email protected]>
cgoodfred
reviewed
May 29, 2024
| ) | ||
| WHERE ocp.source = {{ocp_source_uuid}} | ||
| AND ocp.year = {{year}} | ||
| AND lpad(ocp.month, 2, '0') = {{month}} -- Zero pad the month when fewer than 2 characters | ||
| AND ocp.usage_start >= {{start_date}} | ||
| AND ocp.usage_start < date_add('day', 1, {{end_date}}) | ||
| AND (ocp.resource_id IS NOT NULL AND ocp.resource_id != '') | ||
| AND (ocp.resource_id IS NOT NULL AND ocp.resource_id != '') -- This prevents claimless |
There was a problem hiding this comment.
nitpick: i'm not sure what this comment is telling me, claimless?
There was a problem hiding this comment.
claimless is PVs that do not have a PVC associated with them. I have updated the comment to provide more clarity around that.
lcouzens
previously approved these changes
May 29, 2024
|
Azure run had 4 errors related to timeouts: https://ci.ext.devshift.net/job/koku-pipeline-pr-check-main/2360/ |
Co-authored-by: Michael Skarbek <[email protected]>
maskarb
previously approved these changes
May 29, 2024
|
/retest |
|
successful Azure Smokes: |
myersCody
added
hot-fix-smoke-tests
maskarb
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
COST-4906
Description
This change will update the resource matching to use the CSI volume handle
Testing
pip install --dev4:
The
pv-volume-handle-with-pvcvolume is preset in the ocp on azure daily summary table.TODO:
Release Notes