Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COST-4744] Add data_transfer_direction to create table SQL for OCP on Azure trino tables #5128

Merged
merged 2 commits into from
May 22, 2024

Conversation

cgoodfred
Copy link
Contributor

Jira Ticket

COST-4744

Description

This change will add data_transfer_direction to the relevant OCP on Azure create table SQL for trino tables as a precursor to the SQL updates being merged in. This field is being used in SQL changes in this PR: #5056

Testing

  1. Checkout Branch
  2. Wipe your DB so its fresh
  3. Load OCP on Azure data and verify summary runs with no issues.

Release Notes

  • proposed release note
* [COST-4744](https://issues.redhat.com/browse/COST-4744) Fix some things

@cgoodfred cgoodfred added the azure-smoke-tests pr_check will build the image and run azure + ocp on azure smoke tests label May 22, 2024
@cgoodfred cgoodfred self-assigned this May 22, 2024
@cgoodfred cgoodfred requested review from a team as code owners May 22, 2024 15:28
Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.2%. Comparing base (f0e7d15) to head (a6e4deb).

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #5128     +/-   ##
=======================================
- Coverage   94.2%   94.2%   -0.0%     
=======================================
  Files        378     378             
  Lines      31622   31622             
  Branches    3756    3756             
=======================================
- Hits       29779   29776      -3     
- Misses      1174    1177      +3     
  Partials     669     669             

@cgoodfred cgoodfred merged commit f1ffebd into main May 22, 2024
11 checks passed
@cgoodfred cgoodfred deleted the COST-4744-OCP-Azure-new-trino-field branch May 22, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
azure-smoke-tests pr_check will build the image and run azure + ocp on azure smoke tests smokes-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants