Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COST-4930] Increase max_length for instance_name field #5123

Merged
merged 2 commits into from
May 21, 2024

Conversation

djnakabaale
Copy link
Contributor

@djnakabaale djnakabaale commented May 21, 2024

Jira Ticket

COST-4930

Description

This change will increase the max_length for the instance_name field in the AWSCostEntryLineItemSummaryByEC2Compute table

Testing

  1. Checkout Branch

  2. Run migrations

  3. Launch postgres shell and check to see that the character_maximum_length for instance_name is 256

    postgres=# select column_name, character_maximum_length from information_schema.columns where table_name = 'reporting_awscostentrylineitem_summary_by_ec2_compute' and column_name = 'instance_name';
    column_name  | character_maximum_length 
    ---------------+--------------------------
    instance_name |                      256
    
    

Depends on:

Release Notes

  • proposed release note
* [COST-4930](https://issues.redhat.com/browse/COST-4930) Increase max_length for instance_name field

@djnakabaale djnakabaale added the smoke-tests pr_check will build the image and run minimal required smokes label May 21, 2024
@djnakabaale djnakabaale self-assigned this May 21, 2024
@djnakabaale djnakabaale marked this pull request as ready for review May 21, 2024 16:42
@djnakabaale djnakabaale requested review from a team as code owners May 21, 2024 16:42
Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.2%. Comparing base (ea53681) to head (1073b31).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #5123     +/-   ##
=======================================
- Coverage   94.2%   94.2%   -0.0%     
=======================================
  Files        378     378             
  Lines      31624   31624             
  Branches    3756    3756             
=======================================
- Hits       29780   29778      -2     
  Misses      1177    1177             
- Partials     667     669      +2     

@djnakabaale djnakabaale merged commit ae263b8 into main May 21, 2024
11 checks passed
@djnakabaale djnakabaale deleted the cost-4930-alter-max-length branch May 21, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
smoke-tests pr_check will build the image and run minimal required smokes smokes-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants