Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COST-5044] Revert AWS HCS CCSP Price Estimate #5114

Merged
merged 2 commits into from
May 17, 2024

Conversation

cgoodfred
Copy link
Contributor

Jira Ticket

COST-5044

Description

This change will revert the AWS CCSP price estimate change since that does not take effect yet.

Testing

  1. Checkout Branch
  2. Restart Koku
  3. Load test customer data
  4. See AWS HCS files generated with expected pricing

Release Notes

  • proposed release note
* [COST-5044](https://issues.redhat.com/browse/COST-5044) Fix some things

@cgoodfred cgoodfred requested review from a team as code owners May 17, 2024 12:02
@cgoodfred cgoodfred self-assigned this May 17, 2024
@cgoodfred cgoodfred added the hot-fix-smoke-tests pr_check label to run minimal smoke tests for fast moving bug-fix label May 17, 2024
Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.2%. Comparing base (7bed556) to head (c9dee8e).

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #5114     +/-   ##
=======================================
- Coverage   94.2%   94.2%   -0.0%     
=======================================
  Files        378     378             
  Lines      31624   31624             
  Branches    3756    3756             
=======================================
- Hits       29780   29778      -2     
- Misses      1174    1177      +3     
+ Partials     670     669      -1     

@cgoodfred cgoodfred merged commit 8c696cd into main May 17, 2024
11 checks passed
@cgoodfred cgoodfred deleted the COST-5044-aws-hcs-ccsp-revert branch May 17, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hot-fix-smoke-tests pr_check label to run minimal smoke tests for fast moving bug-fix smokes-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants