Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COST-5024] GCP Return credits field as json in bigquery. #5100

Merged
merged 1 commit into from
May 13, 2024

Conversation

myersCody
Copy link
Contributor

@myersCody myersCody commented May 10, 2024

Jira Ticket

COST-5024

Description

This change will ...

Testing

  1. Checkout Branch
  2. Restart Koku
  3. Hit endpoint or launch shell
    1. You should see ...
  4. Do more things...

Release Notes

  • proposed release note
* [COST-5024](https://issues.redhat.com/browse/COST-5024) Update bigquery to return credits as a json string

@myersCody myersCody requested review from a team as code owners May 10, 2024 21:20
@myersCody myersCody added the gcp-smoke-tests pr_check will build the image and run gcp + ocp on gcp smoke tests label May 10, 2024
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.1%. Comparing base (764a911) to head (2841e29).

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #5100     +/-   ##
=======================================
- Coverage   94.1%   94.1%   -0.0%     
=======================================
  Files        378     378             
  Lines      31579   31579             
  Branches    3754    3754             
=======================================
- Hits       29729   29726      -3     
- Misses      1179    1180      +1     
- Partials     671     673      +2     

@myersCody myersCody changed the title GCP Return credits field as json in bigquery. [COST-5024] GCP Return credits field as json in bigquery. May 13, 2024
@myersCody myersCody merged commit 30b2eb2 into main May 13, 2024
11 checks passed
@myersCody myersCody deleted the to_json_string_credits branch May 13, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gcp-smoke-tests pr_check will build the image and run gcp + ocp on gcp smoke tests smokes-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants