-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[COST-5028] guard against report_status not existing #5099
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5099 +/- ##
=======================================
- Coverage 94.1% 94.1% -0.0%
=======================================
Files 378 378
Lines 31577 31579 +2
Branches 3753 3754 +1
=======================================
- Hits 29728 29725 -3
- Misses 1177 1180 +3
- Partials 672 674 +2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍🏾
return CostUsageReportStatus.objects.get( | ||
report_name=Path(self._report_file).name, manifest_id=self.manifest_id | ||
) | ||
return None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The return None
is implicit, so it could be omitted.
Jira Ticket
COST-5028
Description
This change will prevent task failures when
report_status
does not exist forOCPCloudParquetReportProcessor
.Testing
starting on main:
Release Notes