Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[COST-5015] Azure disk capacity table migration #5090

Merged
merged 12 commits into from
May 16, 2024
Merged

[COST-5015] Azure disk capacity table migration #5090

merged 12 commits into from
May 16, 2024

Conversation

myersCody
Copy link
Contributor

@myersCody myersCody commented May 6, 2024 •
edited
Loading

Jira Ticket

COST-5015

Description

This change will add a table to store the azure disk capacities information.

Testing

  1. Checkout Branch
  2. Run the Migration
  3. Query the table and see values.

Release Notes

  • proposed release note
* [COST-5015](https://issues.redhat.com/browse/COST-5015) Migrations to add azure disk capacities

@myersCody myersCody changed the title [COST-5015] Add azure disk capacity table. [COST-5015] Azure disk capacity table migration May 7, 2024
@myersCody myersCody added skip-migration-check Skip migration test in CI. Useful for separating model changes from the migration. smoke-tests pr_check will build the image and run minimal required smokes labels May 7, 2024
@codecov Codecov
Copy link

codecov bot commented May 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.2%. Comparing base (febeb57) to head (84945ee).

Additional details and impacted files 
@@          Coverage Diff          @@
##            main   #5090   +/-   ##
=====================================
  Coverage   94.2%   94.2%           
=====================================
  Files        378     378           
  Lines      31583   31583           
  Branches    3754    3754           
=====================================
+ Hits       29738   29742    +4     
+ Misses      1175    1172    -3     
+ Partials     670     669    -1

@myersCody myersCody marked this pull request as ready for review May 7, 2024 13:03
@myersCody myersCody requested review from a team as code owners May 7, 2024 13:03
@samdoran samdoran added the django migration Change requires a Django database migration label May 7, 2024
@myersCody
Copy link
Contributor Author

/retest

lcouzens
lcouzens previously approved these changes May 13, 2024
View reviewed changes
@myersCody
Copy link
Contributor Author

One smoke failure definitely unrelated: https://ci.ext.devshift.net/job/koku-pipeline-pr-check-main/2228/

@myersCody myersCody added hot-fix-smoke-tests pr_check label to run minimal smoke tests for fast moving bug-fix and removed smoke-tests pr_check will build the image and run minimal required smokes labels May 16, 2024
@myersCody
Copy link
Contributor Author

/retest

@myersCody myersCody merged commit b125a78 into main May 16, 2024
11 checks passed
@myersCody myersCody deleted the COST-5015-migrations branch May 16, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maskarb maskarb maskarb approved these changes

@lcouzens lcouzens lcouzens left review comments

Assignees
No one assigned
Labels
django migration Change requires a Django database migration hot-fix-smoke-tests pr_check label to run minimal smoke tests for fast moving bug-fix skip-migration-check Skip migration test in CI. Useful for separating model changes from the migration. smokes-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@myersCody @lcouzens @maskarb @samdoran