Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COST-4740] Model updates for OCP on Cloud project daily summary tables #5087

Merged
merged 1 commit into from
May 9, 2024

Conversation

cgoodfred
Copy link
Contributor

Jira Ticket

COST-4740

Description

This change will update the models for the new columns created in the migration here and cannot merge before that migration: #5086

Testing

  1. After the previous migration has merged, you should be able to use Django to query something from the model successfully.
  2. Create and load test customer data
  3. make shell-schema
  4. from reporting.models import OCPAWSCostLineItemProjectDailySummaryP
  5. OCPAWSCostLineItemProjectDailySummaryP.objects.all()
  6. If the migration from the other PR has run you will see this return results successfully, if the migration has not run this will hit a ProgrammingError

Release Notes

  • proposed release note
* [COST-4740](https://issues.redhat.com/browse/COST-4740) Model updates to add new fields to OCP on Cloud Project Daily Summary tables.

@cgoodfred cgoodfred self-assigned this May 4, 2024
Copy link
Contributor

@lcouzens lcouzens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we just need that migration PR merged first.

Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.1%. Comparing base (3b1c16a) to head (c7fb709).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #5087   +/-   ##
=====================================
  Coverage   94.1%   94.1%           
=====================================
  Files        377     377           
  Lines      31375   31384    +9     
  Branches    3724    3724           
=====================================
+ Hits       29531   29540    +9     
- Misses      1173    1175    +2     
+ Partials     671     669    -2     

@lcouzens lcouzens added the smoke-tests pr_check will build the image and run minimal required smokes label May 9, 2024
@lcouzens
Copy link
Contributor

lcouzens commented May 9, 2024

/retest

@samdoran samdoran force-pushed the COST-4740-OCP-Cloud-model-update branch from 3c9050c to c7fb709 Compare May 9, 2024 13:35
@samdoran samdoran marked this pull request as ready for review May 9, 2024 13:35
@samdoran samdoran requested review from a team as code owners May 9, 2024 13:35
@samdoran samdoran enabled auto-merge (squash) May 9, 2024 13:35
@samdoran
Copy link
Contributor

samdoran commented May 9, 2024

Looks like CodeCov is having a moment. 🙄

@samdoran
Copy link
Contributor

samdoran commented May 9, 2024

Third time's a charm. Just waiting on Jenkins.

@samdoran samdoran merged commit 89445a3 into main May 9, 2024
11 checks passed
@samdoran samdoran deleted the COST-4740-OCP-Cloud-model-update branch May 9, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
smoke-tests pr_check will build the image and run minimal required smokes smokes-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants