Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cluster info - grab latest manifest across month boundries. #5079

Merged
merged 1 commit into from
May 1, 2024

Conversation

lcouzens
Copy link
Contributor

@lcouzens lcouzens commented May 1, 2024

Jira Ticket

COST-5009

Description

This change will change our manifest lookup logic to filter for current and previous month. This means we should always have a latest timestamp for statuses even when we enter a new month boundary.

Testing

  1. Checkout Branch
  2. Restart Koku
  3. Hit endpoint or launch shell
    1. You should see ...
  4. Do more things...

Release Notes

  • proposed release note
* [COST-####](https://issues.redhat.com/browse/COST-####) Fix data details (cluster info) timestamps for start of new month 

@lcouzens lcouzens requested review from a team as code owners May 1, 2024 16:25
@lcouzens lcouzens added the smoke-tests pr_check will build the image and run minimal required smokes label May 1, 2024
@lcouzens
Copy link
Contributor Author

lcouzens commented May 1, 2024

/retest

@lcouzens lcouzens enabled auto-merge (squash) May 1, 2024 16:28
@lcouzens lcouzens changed the title Cluster info - grab latest manifest accross month boundries. Cluster info - grab latest manifest across month boundries. May 1, 2024
Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.1%. Comparing base (41bb026) to head (3e11e3f).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #5079   +/-   ##
=====================================
  Coverage   94.1%   94.1%           
=====================================
  Files        377     377           
  Lines      31344   31344           
  Branches    3715    3715           
=====================================
  Hits       29502   29502           
  Misses      1172    1172           
  Partials     670     670           

@lcouzens lcouzens merged commit 5d8b4b4 into main May 1, 2024
10 checks passed
@lcouzens lcouzens deleted the cluster-info-manifest-patch branch May 1, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
smoke-tests pr_check will build the image and run minimal required smokes smokes-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants