Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COST-4947] Remove account and region fields from ProviderInfrastructureMap #5076

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

cgoodfred
Copy link
Contributor

@cgoodfred cgoodfred commented Apr 30, 2024

Jira Ticket

COST-4947

Description

This change will remove account and region from the ProviderInfrastructureMap prior to the migration on the DB.

This follows the suggested flow from the following gist: https://gist.github.com/majackson/493c3d6d4476914ca9da63f84247407b#removing-fields-or-tables

Testing

  1. Smokes should pass

Release Notes

  • proposed release note
* [COST-4947](https://issues.redhat.com/browse/COST-####) Remove account and region from the ProviderInfrastructureMap model

@cgoodfred cgoodfred added smoke-tests pr_check will build the image and run minimal required smokes skip-migration-check Skip migration test in CI. Useful for separating model changes from the migration. labels Apr 30, 2024
@cgoodfred cgoodfred self-assigned this Apr 30, 2024
@cgoodfred cgoodfred marked this pull request as ready for review April 30, 2024 15:05
@cgoodfred cgoodfred requested review from a team as code owners April 30, 2024 15:05
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.1%. Comparing base (5ac84cc) to head (cc02857).

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #5076     +/-   ##
=======================================
- Coverage   94.1%   94.1%   -0.0%     
=======================================
  Files        377     377             
  Lines      31346   31344      -2     
  Branches    3715    3715             
=======================================
- Hits       29506   29504      -2     
+ Misses      1175    1173      -2     
- Partials     665     667      +2     

@cgoodfred cgoodfred merged commit 25a41eb into main Apr 30, 2024
11 checks passed
@cgoodfred cgoodfred deleted the COST-4947-remove-model-fields branch April 30, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-migration-check Skip migration test in CI. Useful for separating model changes from the migration. smoke-tests pr_check will build the image and run minimal required smokes smokes-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants