Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COST-4967] Update Azure Openshift Correlation to be contains. #5062

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

myersCody
Copy link
Contributor

@myersCody myersCody commented Apr 23, 2024

Jira Ticket

COST-4967

Description

This change will update the Azure filtered by OpenShift logic to do a contains using strpos instead of doing an exact matching.

The bug is that their are prefixes and suffixes on the Azure instance-ids that are not not part of OCP's persistent volume names for the customer.

Example:
Azure Instance Id: azure-cloud-prefix-pvc-volume_2
OpenShift PVC name: pvc-volume_2

Testing

  1. Checkout Branch
  2. Upload data
  3. Run this trino query:
select distinct resource_id from reporting_ocpazurecostlineitem_project_daily_summary where service_name='Storage';

See the instance_ids that we added that are partial matches:

 azure-cloud-prefix-pvc-volume_2
 pvc-volume_1-azure_cloud_suffix

Release Notes

  • proposed release note
* [COST-4967](https://issues.redhat.com/browse/COST-4967) Switch to partial matching for correlating Azure to OpenShift resource ids

@myersCody myersCody added the azure-smoke-tests pr_check will build the image and run azure + ocp on azure smoke tests label Apr 23, 2024
@myersCody myersCody self-assigned this Apr 23, 2024
@myersCody myersCody requested review from a team as code owners April 23, 2024 18:39
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Merging #5062 (f23d192) into main (2200b6f) will decrease coverage by 0.0%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #5062     +/-   ##
=======================================
- Coverage   94.1%   94.1%   -0.0%     
=======================================
  Files        377     377             
  Lines      31330   31330             
  Branches    3714    3714             
=======================================
- Hits       29495   29491      -4     
- Misses      1169    1172      +3     
- Partials     666     667      +1     

@myersCody myersCody merged commit 9e1aa1c into main Apr 24, 2024
11 checks passed
@myersCody myersCody deleted the cost-4967-uncorrelated-storage-costs branch April 24, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
azure-smoke-tests pr_check will build the image and run azure + ocp on azure smoke tests smokes-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants