Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[COST-3829] API to read/update source/target tag mappings #4905

Merged
merged 58 commits into from
Feb 14, 2024
Merged

[COST-3829] API to read/update source/target tag mappings #4905

merged 58 commits into from
Feb 14, 2024

Conversation

bacciotti
Copy link
Contributor

Jira Ticket

COST-3829

Description

This change will create the Tag Mapping API CRUD and its unit tests.

Testing

  1. Checkout Branch
  2. Restart Koku
  3. Hit endpoints
    1. v1/settings/tag_mappings/
    2. v1/settings/tag_mappings/child
    3. v1/settings/tag_mappings/child/add
    4. v1/settings/tag_mappings/child/remove
    5. v1/settings/tag_mappings/parent
    6. v1/settings/tag_mappings/parent/remove
  4. Run unit tests tox -e py39 -- api.settings.test.tag_mappings.test_view.SettingsTagMappingViewTestCase

myersCody and others added 30 commits January 15, 2024 15:15
@myersCody
Update models and urls.
f29ead5
@myersCody
Modify the model.
a2d8aee
@myersCody
Fix mistake with related names.
a02b485
@bacciotti
COST-3592: first steps on add endpoint.
d45504e
@bacciotti
Fixing url and adding validations.
7558961
@myersCody
Added some clean up and comments for Lucas.
51d7f50
@myersCody
Add unleash flag & AWS daily summary sql.
92906e6
@bacciotti
Inserted some tests about the validations.
935e106
@bacciotti
Fixing serializer.
7605218
@myersCody
Discover edge case for duplicate keys.
ca90f9c
@bacciotti
Implementing some changes to match the API Expectations doc.
6b9b4c4
@bacciotti
Fixing put method and tests.
65e7c87
@bacciotti
Creating "remove" endpoints and its unit tests.
68e74d2
@bacciotti
Create and implement /child endpoint (ChildView).
9e655cc
@bacciotti
Creating TagMappingChildView filtering.
59b83f0
@bacciotti
Child view test.
46ecf3c
@bacciotti
Parent endpoint and its unit tests.
8d1a75d
@bacciotti
wip
9a57551
@bacciotti
wip
c2358d4
@bacciotti
Fixing filter.
be43707
@bacciotti
Tests
4aae7fa
@bacciotti
wip
3cefc95
@myersCody @bacciotti
Discover edge case for duplicate keys.
78b3c3f 
Implementing some changes to match the API Expectations doc.

Fixing put method and tests.

Creating "remove" endpoints and its unit tests.

Create and implement /child endpoint (ChildView).

Creating TagMappingChildView filtering.

Child view test.

Parent endpoint and its unit tests.

wip

wip

Fixing filter.

Tests
@bacciotti
Creating API endpoints and its unit tests.
8d5aaf6
@bacciotti
Merge remote-tracking branch 'origin/tag_mapping' into tag_mapping
93e581f
@myersCody
Figure out a way to handle our edge cases.
d9ad719
@myersCody
Simplify and fix edge case.
ebc7c24
@myersCody
Adding sql changes for other providers.
5b14b7b
@myersCody
Cherry pick sql changes over to other branches.
5d0dd40
@myersCody
Remove TODO comments.
495737f
maskarb
maskarb reviewed Feb 13, 2024
View reviewed changes
Copy link
Member

@maskarb maskarb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial feedback:

koku/api/settings/tag_mappings/query_handler.py Outdated Show resolved Hide resolved
koku/api/settings/tag_mappings/serializers.py Outdated Show resolved Hide resolved
koku/api/settings/tag_mappings/view.py Outdated Show resolved Hide resolved
koku/api/settings/test/tag_mappings/test_view.py Outdated Show resolved Hide resolved
koku/api/settings/test/tag_mappings/test_view.py Outdated Show resolved Hide resolved
koku/api/settings/test/tag_mappings/test_view.py Outdated Show resolved Hide resolved
koku/api/settings/test/tag_mappings/test_view.py Outdated Show resolved Hide resolved
koku/api/settings/tag_mappings/view.py Outdated Show resolved Hide resolved
koku/api/settings/tag_mappings/view.py Outdated Show resolved Hide resolved
koku/api/settings/tag_mappings/view.py Outdated Show resolved Hide resolved
@myersCody myersCody removed the smoke-tests pr_check will build the image and run minimal required smokes label Feb 13, 2024
@myersCody myersCody added the smoke-tests pr_check will build the image and run minimal required smokes label Feb 13, 2024
maskarb
maskarb reviewed Feb 13, 2024
View reviewed changes
Copy link
Member

@maskarb maskarb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question, otherwise it looks pretty good!

koku/api/settings/tags/mapping/serializers.py Outdated Show resolved Hide resolved
@maskarb
Copy link
Member

maskarb commented Feb 14, 2024

/retest

@bacciotti bacciotti merged commit d9abce7 into main Feb 14, 2024
11 checks passed
@bacciotti bacciotti deleted the tag_mapping branch February 14, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myersCody myersCody myersCody left review comments

@maskarb maskarb maskarb approved these changes

Assignees
No one assigned
Labels
smoke-tests pr_check will build the image and run minimal required smokes smokes-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bacciotti @maskarb @myersCody