set max retry for trino connection #4898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maskarb
added
the
smoke-tests
|
/retest |
samdoran
approved these changes
Feb 7, 2024
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4898 +/- ##
=====================================
Coverage 94.0% 94.0%
=====================================
Files 370 370
Lines 30563 30563
Branches 3645 3645
=====================================
+ Hits 28715 28717 +2
+ Misses 1188 1187 -1
+ Partials 660 659 -1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The default max-attempts in the trino library is 3. This gives the connection approx 1.4 seconds to re-establish a connection to the trino-coordinator. During a cluster upgrade, the cutover to the new coordinator likely takes longer than 1.4 seconds.
This PR sets the max-attempts count to 9 which will give the workers approx 100 seconds to re-establish the connection to the coordinator.