Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[COST-4278] add terminationGracePeriodSeconds to celery workers #4883

Merged
merged 3 commits into from
Jan 31, 2024
Merged

[COST-4278] add terminationGracePeriodSeconds to celery workers #4883

merged 3 commits into from
Jan 31, 2024

Conversation

maskarb
Copy link
Member

@maskarb maskarb commented Jan 30, 2024 •
edited
Loading

Jira Ticket

COST-4278

Description

This change will add a 1 hour terminationGracePeriodSeconds to all celery workers.

Testing

  1. Checkout Branch
  2. Restart Koku
  3. Hit endpoint or launch shell
    1. You should see ...
  4. Do more things...

Notes

...

@maskarb maskarb requested review from a team as code owners January 30, 2024 20:30
@maskarb maskarb added the hot-fix-smoke-tests pr_check label to run minimal smoke tests for fast moving bug-fix label Jan 30, 2024
@maskarb
Copy link
Member Author

maskarb commented Jan 30, 2024

/retest

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@maskarb maskarb merged commit 12e43c4 into main Jan 31, 2024
12 checks passed
@maskarb maskarb deleted the cost-4278-worker-warm-shutdown branch January 31, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdoran samdoran samdoran approved these changes

@myersCody myersCody myersCody approved these changes

Assignees
No one assigned
Labels
hot-fix-smoke-tests pr_check label to run minimal smoke tests for fast moving bug-fix smokes-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maskarb @samdoran @myersCody