Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COST-4466] Migration to clean up old column for cost category #4821

Merged
merged 7 commits into from
Jan 9, 2024

Conversation

myersCody
Copy link
Contributor

Jira Ticket

COST-4466

Description

This change will add a migration to clean up the old column for cost category table.

Testing

  1. Checkout Branch
  2. Restart Koku
  3. Hit endpoint or launch shell
    1. You should see ...
  4. Do more things...

Notes

...

@myersCody myersCody requested review from a team as code owners December 4, 2023 20:34
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Merging #4821 (cca9efb) into main (62481c7) will increase coverage by 0.0%.
The diff coverage is n/a.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #4821   +/-   ##
=====================================
  Coverage   94.0%   94.0%           
=====================================
  Files        365     365           
  Lines      30288   30287    -1     
  Branches    3603    3603           
=====================================
+ Hits       28462   28465    +3     
+ Misses      1162    1159    -3     
+ Partials     664     663    -1     

@samdoran samdoran added the django migration Change requires a Django database migration label Dec 5, 2023
@myersCody myersCody added the smoke-tests pr_check will build the image and run minimal required smokes label Dec 11, 2023
@myersCody
Copy link
Contributor Author

/retest

Copy link

sonarqubecloud bot commented Jan 8, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@samdoran samdoran changed the title [COST-4466] Migration to clean up old column for cost category. [COST-4466] Migration to clean up old column for cost category Jan 9, 2024
@samdoran samdoran merged commit 3de49ac into main Jan 9, 2024
10 checks passed
@samdoran samdoran deleted the cost-4466-migration branch January 9, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
django migration Change requires a Django database migration smoke-tests pr_check will build the image and run minimal required smokes smokes-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants