Sources GCP BigQuery Table ID should be maintained while updating app-settings #2646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2646 +/- ##
======================================
Coverage 94.8% 94.8%
======================================
Files 282 282
Lines 21663 21665 +2
Branches 2455 2455
======================================
+ Hits 20531 20533 +2
Misses 680 680
Partials 452 452 |
adberglund
approved these changes
Feb 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A miss from yesterday. We need to ensure that the BigQuery Table ID stays in tact when we update GCP application settings. Table ID is not tracked by platform sources since it is detected by Cost Management and not something the user enters.
Testing
GCP crud testing in QA environment was successful